-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schematics): make v6 migration work #10853
Conversation
@@ -32,7 +32,7 @@ const allScssGlob = join(buildConfig.packagesDir, '**/*.scss'); | |||
const schematicsGlobs = [ | |||
// File templates and schemas are copied as-is from source. | |||
join(schematicsDir, '**/+(data|files)/**/*'), | |||
join(schematicsDir, '**/+(schema|collection).json'), | |||
join(schematicsDir, '**/+(schema|collection|migration).json'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be updated as well? https://github.com/angular/material2/blob/master/src/lib/schematics/BUILD.bazel#L19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good catch. Done.
@@ -20,7 +20,7 @@ | |||
"docs": "gulp docs", | |||
"api": "gulp api-docs" | |||
}, | |||
"version": "6.0.0-rc.5", | |||
"version": "6.0.0-rc.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it going from rc.5 to rc.11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is because this was published to NPM as rc.11 already, and this is an after-the-fact update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep; it's not yet possible to test ng update
without publishing to npm
This includes: * Adding missing schema json to package * Add missing packageGroup entries to material, cdk, and moment-adapter * Move schematics for migration to the migrate-specific schema * Bump version to 6.0.0-rc.11
de2c754
to
39abfcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This includes: